Add --mir-version command line option. solves MirServer/mir#3058 #3130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saviq
requested changes
Nov 16, 2023
There was a problem hiding this comment.
Hi @pillowtrucker thanks for this!
Some suggestions inline.
Co-authored-by: Michał Sawicz <michal@sawicz.net>
pillowtrucker
force-pushed
the
warmup2
branch
from
0593ca1
to
9f31c8e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3130 +/- ##
==========================================
- Coverage 77.83% 77.82% -0.01%
==========================================
Files 1064 1074 +10
Lines 74416 74867 +451
==========================================
+ Hits 57923 58267 +344
- Misses 16493 16600 +107 ☔ View full report in Codecov by Sentry. |
|
Replied in the remaining thread. I'm also not sure if there was a good reason why |
Saviq
reviewed
Nov 17, 2023
Saviq
reviewed
Nov 17, 2023
AlanGriffiths
requested changes
Nov 17, 2023
pillowtrucker
force-pushed
the
warmup2
branch
from
2bac78e
to
20b102d
Compare
|
pushed new rebased version ignoring the stray commits from before, added a comment about the thrown exceptions and tried to DRY it a little bit |
Saviq
reviewed
Nov 17, 2023
added 2 commits
November 17, 2023 13:28
This reverts commit 20b102d.
AlanGriffiths
approved these changes
Nov 17, 2023
Saviq
reviewed
Nov 17, 2023
…tWithOutput usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with miral-shell built from within this repo and with my own compositor linking against this version.
I also looked in unit tests to see if I could add it there, but the existing test for options uses test data rather than real responses from built artifacts. Please let me know if there's another one that I've missed that would be suitable for this.