Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We can't safely destroy objects whose implementation may lie in a .so that's been unloaded. #334

Merged
merged 1 commit into from Apr 19, 2018
Merged

We can't safely destroy objects whose implementation may lie in a .so that's been unloaded. #334

merged 1 commit into from Apr 19, 2018

Conversation

AlanGriffiths
Copy link
Contributor

Fixes #327, #112

wmww
wmww approved these changes Apr 19, 2018
View reviewed changes
Copy link
Contributor

@wmww wmww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work
bors r+

bors bot added a commit that referenced this pull request Apr 19, 2018
@bors @AlanGriffiths
Merge #334
e970379 
334: We can't safely destroy objects whose implementation may lie in a .so that's been unloaded. r=wmww a=AlanGriffiths

Fixes #327, #112

Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
@bors bors bot merged commit e7873e2 into master Apr 19, 2018
@bors
Copy link
Contributor

bors bot commented Apr 19, 2018

Build succeeded

@bors bors bot deleted the fix-328 branch April 19, 2018 14:12
wmww pushed a commit that referenced this pull request Apr 19, 2018
@bors @AlanGriffiths
Merge #334
af17479 
334: We can't safely destroy objects whose implementation may lie in a .so that's been unloaded. r=wmww a=AlanGriffiths

Fixes #327, #112

Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmww wmww wmww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlanGriffiths @wmww