Remove BufferStream::resize()
#767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be noted that window resize still isn't perfect. When resizing from the top left there is a slight jitter in lower and right edges. This is due Mir moving, clipping and rendering the buffer slightly faster than the client can respond with a resized buffer. The fix would probably be something like having the surface ask the client to resize without actually performing the resize on itself. |
AlanGriffiths
approved these changes
Mar 21, 2019
bors bot
added a commit
that referenced
this pull request
Mar 21, 2019
767: Remove `BufferStream::resize()` r=AlanGriffiths a=wmww A `BufferStream`'s size is now just the size of the most recent buffer (or the initial size sent to the constructor, if there is no buffer yet). This simplifies the code, fixes #604, and the non-atomic resize problem noted in a TODO in wl_surface.cpp. Co-authored-by: William Wold <wm@wmww.sh>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
BufferStream's size is now just the size of the most recent buffer (or the initial size sent to the constructor, if there is no buffer yet). This simplifies the code, fixes #604, and the non-atomic resize problem noted in a TODO in wl_surface.cpp.