Upgrading Squeekboard will break keyboard size

[wmww]

We currently use Squeekboard v1.17.1, which works well. However v1.18.0, v1.19.0 and master at time of writing all draw the keyboard much too small, especially on nerrow, tall displays.

[Saviq]

@wmww with #53 (meaning v1.21.0), I'm not seeing anything wrong?

[AlanGriffiths]

With 22/edge/pr53

With stable

[AlanGriffiths]

Hmm, actually the above is a difference between 22/beta and 22/edge

[Saviq]

Hmm, actually the above is a difference between 22/beta and 22/edge

Yes, edge is built without the source-tag:.

And ACK, was looking at "narrow, tall displays".

[wmww]

I guess if you get sufficiently narrow and sufficiently tall the problem goes away

[jrmcpeek]

#64 introduces this (unexpected? undesired?) behavior to the 22/beta channel.

It looks like the Canonical repos (https://git.launchpad.net/ubuntu/+source/squeekboard) point to 1.22 (as of this comment), but the snaps are still flagged as 1.17:

22/beta:          65-sqbd1.17.1-0ubuntu1 2023-12-05 (525) 90MB -

This produces the documented issues above on a 1080p setup:

[Saviq]

Thanks for noticing @jrmcpeek, I should've gone for jammy there.

https://packages.ubuntu.com/search?keywords=squeekboard

Will also fix the version string, that should've been taken from debian/changelog of the checked out source :/

[Saviq]

Thanks for noticing @jrmcpeek, I should've gone for jammy there.

Oh, I did!

https://github.com/MirServer/ubuntu-frame-osk/blob/a5fc8b9b0afee324d485f8257ebd9cfcfed4c034/snap/snapcraft.yaml#L106-L108

So the version number is correct, it's just that the same problem occurred in the Jammy release.

It looks like one of these patches (which are backported in the Ubuntu source) must be the problem:

https://gitlab.gnome.org/World/Phosh/squeekboard/-/commit/68087a125cf26f364e200ef9f6aedeeb82218d66
https://gitlab.gnome.org/World/Phosh/squeekboard/-/merge_requests/548

Looks like we'll need to dig into it and find a proper fix.

[jrmcpeek]

@Saviq

Looks like we'll need to dig into it and find a proper fix.

So, until then, should pointing to the Ubuntu repos be reverted for beta and only tracked to edge?

As it stands, the usability of the 22/beta is poor, but I'd also hate to move our pre-production devices to 22/stable and then wake up one day and see that the production machines received an update exhibiting this same behavior without a chance to see it and raise the concern (as was done here).

[Saviq]

@jrmcpeek I reverted this change on main now, beta will get updated in a couple hours latest.

[svncibrahim]

I think I've fixed the sizing problem that started after Squeekboard v0.17.1. The main issue came from changes made to how the preferred_height was calculated, especially for the Librem 5's screen. To solve this, I created a patch using a system that scales based on a percentage of pixels, like how GNOME's virtual keyboard works

I tested this patch on vertical and horizontal screens and didn't find any problems. I tested the patch using v1.24.0, but it should work for versions as far back as v19.0.0.

height_scale.patch

[Saviq]

Thanks @svncibrahim, that will help for sure, did you try submitting that upstream, yet?

[svncibrahim]

@Saviq I've sent it upstream. It's pending review now.

[Saviq]

Thanks @svncibrahim, where can I monitor it? I don't see it in https://gitlab.gnome.org/World/Phosh/squeekboard/-/merge_requests ?

[svncibrahim]

@Saviq I had submitted this as a pull request to this repository. #72 , But I will also submit the main squeekboard repository