Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy geometry headers from Mir #283

Merged
merged 3 commits into from May 16, 2023
Merged

Copy geometry headers from Mir #283

merged 3 commits into from May 16, 2023

Conversation

wmww
Copy link
Contributor

@wmww wmww commented Mar 9, 2023

We've discussed doing this in the past, and the recent work I've done on popup positioning logic got especially annoying without some sort of proper geometry types. The complexity of the Mir ones is arguably overkill for wlcs (some might even argue overkill for Mir), but they're familiar to the Mir team and easy to use. I adapted the layer shell tests to show how they can be used in WLCS, but there's still a lot more work and code churn to fully use them.

Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe these should just move to a new package. (Unless we consider mir-core to be sufficiently lightweight?)

@RAOF RAOF changed the title [RFC] Copy geometry headers from Mir Copy geometry headers from Mir May 16, 2023
Copy link
Contributor

@RAOF RAOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My memory of Prague is that everyone was varying degrees of OK with this, and we can pull things out later if necessary.

This nicely simplifies a bunch of things.

@RAOF RAOF added this pull request to the merge queue May 16, 2023
Merged via the queue into main with commit b356a38 May 16, 2023
@RAOF RAOF deleted the add-geom branch May 16, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants