fix: fixing rpc return values for unity 2021.2 #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed. |
making Skeleton method static and adding the behaviour as the first arg. Previously method was an instance method,. and behaviour was assumed to be first arg, this seemed to work in older versions of unity but has broken in 2021.2 when the method has a return value
James-Frowen
force-pushed
the
return-rpc-fix-2
branch
from
ada7cd3
to
9912654
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Dec 4, 2021
## [113.0.3](v113.0.2...v113.0.3) (2021-12-04) ### Bug Fixes * fixing rpc return values for unity 2021.2 ([#1000](#1000)) ([a6ee5e8](a6ee5e8))
|
🎉 This PR is included in version 113.0.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
making Skeleton method static and adding the behaviour as the first arg.
Previously method was an instance method, and
behaviourwas assumed to be first arg, this seemed to work in older versions of unity but has broken in 2021.2 when the method has a return valuefixes: #997