fix: adding ability to start the Client & Server from interfaces #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reverted the support of host mode in the interface methods to remove the need to expose internal methods in |
James-Frowen
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
May 24, 2022
## [123.1.3](v123.1.2...v123.1.3) (2022-05-24) ### Bug Fixes * adding ability to start the Client & Server from interfaces ([#1079](#1079)) ([61e8d6b](61e8d6b))
|
🎉 This PR is included in version 123.1.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stems from this conversation. It adds the ability to start the server from the
INetworkServerand connect from theINetworkClient.Starting the host is also possible from the interfaces, however it required making several methods
publicinstead ofinternalto allow for the interfaces to decouple theNetworkServerandNetworkClient. Let me know if this is ok.