Authenticator v2 #1147
Closed
Authenticator v2 #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AddConnection does unnecessary checks. InvokeLocalConnected Connected can just be called within server after localClient.ConnectHost
need callback to handle arraysegment<byte> because arrays are re-used
waiting for 1 message should only be used client side so it is fine if we include a reference too client here
only set via code so far, will add gui to log settings to automatically add later
James-Frowen
force-pushed
the
authenticator-v2
branch
from
b454df7
to
9913ad4
Compare
|
merged manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.