Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PlayerSpawner component #123

Merged
merged 11 commits into from
Mar 26, 2020
Merged

feat: PlayerSpawner component #123

merged 11 commits into from
Mar 26, 2020

Conversation

paulpach
Copy link
Contributor

NetworkManager is no longer responsible for adding default player.

Now there is a dedicated component that spawns the default player. If you don't add it, no player is automatically added.

Assets/Mirror/Runtime/NetworkStartPosition.cs Outdated Show resolved Hide resolved
Assets/Mirror/Runtime/PlayerSpawner.cs Outdated Show resolved Hide resolved
Assets/Mirror/Runtime/PlayerSpawner.cs Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Mar 26, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 18 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@paulpach paulpach merged commit e8b933d into master Mar 26, 2020
@paulpach paulpach deleted the playerspawner branch March 26, 2020 21:37
github-actions bot pushed a commit that referenced this pull request Mar 26, 2020
# [29.0.0](28.0.0-master...29.0.0-master) (2020-03-26)

### Features

* PlayerSpawner component ([#123](#123)) ([e8b933d](e8b933d))

### BREAKING CHANGES

* NetworkManager no longer spawns the player.  You need to add PlayerSpawner component if you want that behavior
github-actions bot pushed a commit that referenced this pull request Mar 26, 2020
BREAKING CHANGE: NetworkManager no longer spawns the player.  You need to add PlayerSpawner component if you want that behavior
github-actions bot pushed a commit that referenced this pull request Mar 26, 2020
# [29.0.0](28.0.0-master...29.0.0-master) (2020-03-26)

### Features

* PlayerSpawner component ([#123](#123)) ([e8b933d](e8b933d))

### BREAKING CHANGES

* NetworkManager no longer spawns the player.  You need to add PlayerSpawner component if you want that behavior
@github-actions
Copy link
Contributor

🎉 This PR is included in version 29.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants