remove NetworkConnection.isAuthenticated #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this field is not needed anymore, we simply don't register handlers until the connection is authenticated. Eliminates extra state tracking from NetworkConnections BREAKING CHANGE: Remove isAuthenticated
Lymdun
requested changes
Apr 9, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Lymdun
approved these changes
Apr 10, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Apr 10, 2020
* remove NetworkConnection.isAuthenticated this field is not needed anymore, we simply don't register handlers until the connection is authenticated. Eliminates extra state tracking from NetworkConnections BREAKING CHANGE: Remove isAuthenticated * Fix typo * Fix smells * Remove smells
|
🎉 This PR is included in version 34.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this field is not needed anymore, we simply don't register
handlers until the connection is authenticated.
Eliminates extra state tracking from NetworkConnections
BREAKING CHANGE: Remove NetworkConnection.isAuthenticated