feat: add Send and Receive #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpach
reviewed
Apr 27, 2020
Comment on lines
17
to
20
| void RegisterHandler<T1, T2>(Action<T1> handler) where T1 : IMessageBase where T2 : IMessageBase, new(); | ||
|
|
||
| void RegisterHandler<T1, T2>(Action<INetworkConnection, T1> handler) where T1 : IMessageBase where T2 : IMessageBase, new(); | ||
|
|
There was a problem hiding this comment.
You would register a function in this case that returns T2
Suggested change
| void RegisterHandler<T1, T2>(Action<T1> handler) where T1 : IMessageBase where T2 : IMessageBase, new(); | |
| void RegisterHandler<T1, T2>(Action<INetworkConnection, T1> handler) where T1 : IMessageBase where T2 : IMessageBase, new(); | |
| void RegisterHandler<T1, T2>(Func<T1, T2> handler) where T1 : IMessageBase where T2 : IMessageBase, new(); | |
| void RegisterHandler<T1, T2>(Func<INetworkConnection, T1, T2> handler) where T1 : IMessageBase where T2 : IMessageBase, new(); | |
There was a problem hiding this comment.
fixed this and it helped me solve more of the puzzle. But now I am unsure what to do with: MessageHandler(handler). I think we need a new version of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a shot at adding as much of this as I could figure out. Clearly not done yet.