Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal lifecycle events #217

Merged
merged 2 commits into from
May 18, 2020
Merged

Internal lifecycle events #217

merged 2 commits into from
May 18, 2020

Conversation

uweeby
Copy link
Member

@uweeby uweeby commented May 14, 2020

No description provided.

should never be called by users directly. instead they should add listener to the event.
@sonarcloud
Copy link

sonarcloud bot commented May 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Lymdun Lymdun merged commit cbeea7d into master May 18, 2020
github-actions bot pushed a commit that referenced this pull request May 24, 2020
* make event methods internal

should never be called by users directly. instead they should add listener to the event.

* update interfaces
@github-actions
Copy link
Contributor

🎉 This PR is included in version 34.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@uweeby uweeby deleted the internalLifecycleEvents branch June 20, 2020 14:02
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants