feat: Component based NetworkSceneManager #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready related smell will be fixed outside this PR. |
related to state that no longer exists and explaining the importance of logging
|
LGTM, very good work |
paulpach
approved these changes
Jul 10, 2020
|
SonarCloud Quality Gate failed.
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2020
# [35.0.0](34.13.0-master...35.0.0-master) (2020-07-10) ### Features * Component based NetworkSceneManager ([#244](#244)) ([7579d71](7579d71)) ### BREAKING CHANGES * NetworkManager no longer handles scene changes
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2020
Refactored Scene management into it's own component BREAKING CHANGE: NetworkManager no longer handles scene changes
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2020
# [35.0.0](34.13.0-master...35.0.0-master) (2020-07-10) ### Features * Component based NetworkSceneManager ([#244](#244)) ([7579d71](7579d71)) ### BREAKING CHANGES * NetworkManager no longer handles scene changes
|
🎉 This PR is included in version 35.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the code has been moved from NetworkManager into a new class NetworkSceneManager. NetworkManager is now only responsible for HostMode helpers and some headless calls.
The OnValidate checks are intended to provide the default implementation of NetworkSceneManager if one is not provided by the end user. So the default behaviors and examples will still function.
All tests pass locally.
There are some issues present in the examples that are present in master so they are not new. I am marking this WIP as I would like to test more and get feedback on the changes.
I would like to see the Ready/NotReady code moved into NetworkSceneManager also but its currently hooked into alot of places. I will likely follow up with that change at a later time.
The rest of NetworkManager will also be condensed into better HostMode in a separate change. For now for compatibility I am leaving it.