feat: New NetworkManagerHud #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions bot
pushed a commit
that referenced
this pull request
Aug 31, 2020
# [43.5.0](v43.4.2...v43.5.0) (2020-08-31) ### Features * New NetworkManagerHud ([#340](#340)) ([267f513](267f513))
|
🎉 This PR is included in version 43.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Could not get #307 to rebase with the conflicts)
Replaces the old OnGUI solution with a prefab under a canvas. Setting it up is as simple as adding a canvas to the scene if it does not already have one. Dragging the prefab under that canvas. Then adding a reference to the existing NetworkManager. From there it functions the same as the old solution.
image
Moved this and the RunInBackground script into a Common folder under Examples as both of these things are generally quickly replaced and never used in production.
Note: The massive increase in LOC is from the addition of the prefab to the existing examples. The actual HUD logic mostly moved out of code and into the Unity UI via GameObjects and buttons. The LOC dropped from 150 to 50 for what that's worth.
Also since its no longer based on OnGUI it means that more of the remaining code is testable.