Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Component based Ready system #358

Merged
merged 10 commits into from
Sep 28, 2020
Merged

feat: Component based Ready system #358

merged 10 commits into from
Sep 28, 2020

Conversation

uweeby
Copy link
Member

@uweeby uweeby commented Sep 25, 2020

No description provided.

@uweeby uweeby added Work In Progess Shouldn't be merged yet Needs testing labels Sep 25, 2020
@uweeby uweeby mentioned this pull request Sep 27, 2020
Closed
@uweeby
Copy link
Member Author

uweeby commented Sep 27, 2020

The 10% duplication is due to the existing Ready code still being in the codebase. That will be removed via #362 or similar.

@uweeby uweeby removed Work In Progess Shouldn't be merged yet Needs testing labels Sep 28, 2020
@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

91.2% 91.2% Coverage
11.1% 11.1% Duplication

@uweeby uweeby merged commit 23b0afc into master Sep 28, 2020
@uweeby uweeby deleted the compReady branch September 28, 2020 15:41
github-actions bot pushed a commit that referenced this pull request Sep 28, 2020
@semantic-release-bot
chore(release): 44.1.0 [skip ci]
71c81e7 
# [44.1.0](v44.0.0...v44.1.0) (2020-09-28)

### Bug Fixes

* fixing new import ([bdd81e3](bdd81e3))

### Features

* Component based Ready system ([#358](#358)) ([23b0afc](23b0afc))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 44.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@uweeby uweeby mentioned this pull request Sep 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@uweeby @paulpach