Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: Remove GameObject sync #370

Merged
merged 1 commit into from
Oct 2, 2020
Merged

breaking: Remove GameObject sync #370

merged 1 commit into from
Oct 2, 2020

Conversation

Lymdun
Copy link
Member

@Lymdun Lymdun commented Sep 30, 2020 •
edited by paulpach

Synchronizing generic gameobject is not type safe. There is no guarantee that the gameobject has a NetworkIdentity.
This pr removes that feature, you can no longer do:

[SyncVar]
public GameObject someObject

Note, you can accomplish the same thing using NetworkIdentity:

[SyncVar]
public NetworkIdentity someObject;

but it is safer because you can only assign objects that have a NetworkIdentity.

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@paulpach paulpach merged commit 5b223fa into master Oct 2, 2020
@paulpach paulpach deleted the remove_go_syncvar branch October 2, 2020 15:29
github-actions bot pushed a commit that referenced this pull request Oct 2, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
e08125e 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-02)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))

### Features

* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### BREAKING CHANGES

* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 2, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
574bef2 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-02)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))

### Features

* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### BREAKING CHANGES

* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 2, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
4284e7c 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-02)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))

### Features

* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### BREAKING CHANGES

* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 2, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
8f3b3df 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-02)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))

### Features

* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### BREAKING CHANGES

* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 2, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
c12c795 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-02)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))

### Features

* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### BREAKING CHANGES

* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 2, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
a369658 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-02)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))

### Features

* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### BREAKING CHANGES

* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 2, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
d7209a9 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-02)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))

### Features

* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### BREAKING CHANGES

* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 3, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
a76eb26 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-03)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))

### Features

* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### BREAKING CHANGES

* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 4, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
41ba643 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-04)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))
* examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e))

### Features

* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### BREAKING CHANGES

* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 4, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
4371a4b 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-04)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* adding namespace for sonar bug ([2ed0859](2ed0859))
* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))
* examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e))

### Features

* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### BREAKING CHANGES

* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 4, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
31cc3f0 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-04)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* adding namespace for sonar bug ([2ed0859](2ed0859))
* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))
* examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e))
* networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be))

### Features

* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### BREAKING CHANGES

* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 4, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
0e5cbda 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-04)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* adding namespace for sonar bug ([2ed0859](2ed0859))
* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))
* examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e))
* networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be))

### Features

* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### BREAKING CHANGES

* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 4, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
6ba1eaa 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-04)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* adding namespace for sonar bug ([2ed0859](2ed0859))
* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))
* examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e))
* networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be))

### Features

* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### BREAKING CHANGES

* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 5, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
04f8c2c 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-05)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* adding namespace for sonar bug ([2ed0859](2ed0859))
* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))
* Examples can exit property in client mode ([35faaf3](35faaf3))
* examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e))
* networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be))

### Features

* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### BREAKING CHANGES

* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 5, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
80c9d17 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-05)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* adding namespace for sonar bug ([2ed0859](2ed0859))
* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))
* Examples can exit property in client mode ([35faaf3](35faaf3))
* examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e))
* networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be))

### Features

* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### BREAKING CHANGES

* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 6, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
6445a70 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-06)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* access NI on disabled objects ([#383](#383)) ([0ab4c60](0ab4c60))
* adding namespace for sonar bug ([2ed0859](2ed0859))
* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))
* Examples can exit property in client mode ([35faaf3](35faaf3))
* examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e))
* networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be))
* nre modifying syncvars that have not been spawned ([69883c5](69883c5))

### Features

* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### Performance Improvements

* Only synchronize dirty objects ([#381](#381)) ([64fd6ed](64fd6ed))

### BREAKING CHANGES

* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 6, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
737d77a 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-06)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* access NI on disabled objects ([#383](#383)) ([0ab4c60](0ab4c60))
* adding namespace for sonar bug ([2ed0859](2ed0859))
* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))
* Examples can exit property in client mode ([35faaf3](35faaf3))
* examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e))
* networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be))
* nre modifying syncvars that have not been spawned ([69883c5](69883c5))

### Features

* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### Performance Improvements

* Only synchronize dirty objects ([#381](#381)) ([64fd6ed](64fd6ed))
* Remove 2 messages when player connects ([#384](#384)) ([c40e0fd](c40e0fd))

### BREAKING CHANGES

* It is no longer guaranteed that all objects are spawned before we start calling events

* fix object spawning on scene change

* remove unused variable

Co-authored-by: uwee <uweenukr@gmail.com>
* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 6, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
d3f7209 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-06)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* access NI on disabled objects ([#383](#383)) ([0ab4c60](0ab4c60))
* adding namespace for sonar bug ([2ed0859](2ed0859))
* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))
* Examples can exit property in client mode ([35faaf3](35faaf3))
* examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e))
* Lobby comp should not reference NetworkConnection.IsReady ([#385](#385)) ([6a1a190](6a1a190))
* networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be))
* nre modifying syncvars that have not been spawned ([69883c5](69883c5))

### Features

* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### Performance Improvements

* Only synchronize dirty objects ([#381](#381)) ([64fd6ed](64fd6ed))
* Remove 2 messages when player connects ([#384](#384)) ([c40e0fd](c40e0fd))

### BREAKING CHANGES

* It is no longer guaranteed that all objects are spawned before we start calling events

* fix object spawning on scene change

* remove unused variable

Co-authored-by: uwee <uweenukr@gmail.com>
* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 6, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
3c7625a 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-06)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* access NI on disabled objects ([#383](#383)) ([0ab4c60](0ab4c60))
* adding namespace for sonar bug ([2ed0859](2ed0859))
* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))
* Examples can exit property in client mode ([35faaf3](35faaf3))
* examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e))
* Lobby comp should not reference NetworkConnection.IsReady ([#385](#385)) ([6a1a190](6a1a190))
* networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be))
* nre modifying syncvars that have not been spawned ([69883c5](69883c5))

### Features

* Add IncludeOwner option to SendToAll ([#387](#387)) ([6b0a005](6b0a005))
* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### Performance Improvements

* Only synchronize dirty objects ([#381](#381)) ([64fd6ed](64fd6ed))
* Remove 2 messages when player connects ([#384](#384)) ([c40e0fd](c40e0fd))

### BREAKING CHANGES

* It is no longer guaranteed that all objects are spawned before we start calling events

* fix object spawning on scene change

* remove unused variable

Co-authored-by: uwee <uweenukr@gmail.com>
* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
github-actions bot pushed a commit that referenced this pull request Oct 7, 2020
@semantic-release-bot
chore(release): 47.0.0 [skip ci]
9b0a1a3 
# [47.0.0](v46.2.0...v47.0.0) (2020-10-07)

### breaking

* Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa))
* Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305)

### Bug Fixes

* access NI on disabled objects ([#383](#383)) ([0ab4c60](0ab4c60))
* adding namespace for sonar bug ([2ed0859](2ed0859))
* bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5))
* Bug with  NI destroy order ([#374](#374)) ([485f78b](485f78b))
* Examples can exit property in client mode ([35faaf3](35faaf3))
* examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e))
* Lobby comp should not reference NetworkConnection.IsReady ([#385](#385)) ([6a1a190](6a1a190))
* networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be))
* nre modifying syncvars that have not been spawned ([69883c5](69883c5))

### Features

* Add IncludeOwner option to SendToAll ([#387](#387)) ([6b0a005](6b0a005))
* new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3))
* support Jagged arrays ([0267dbe](0267dbe))

### Performance Improvements

* Only synchronize dirty objects ([#381](#381)) ([64fd6ed](64fd6ed))
* Remove 2 messages when player connects ([#384](#384)) ([c40e0fd](c40e0fd))

### BREAKING CHANGES

* It is no longer guaranteed that all objects are spawned before we start calling events

* fix object spawning on scene change

* remove unused variable

Co-authored-by: uwee <uweenukr@gmail.com>
* You can no longer use gameobjects in syncvars
* Serialize and Deserialize methods in synclists don't do anything anymore

* Remove old comment

* Fix compilatio error
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2020

🎉 This PR is included in version 47.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lymdun @paulpach