Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users must initialize SyncLists #391

Merged
merged 1 commit into from
Oct 11, 2020
Merged

Users must initialize SyncLists #391

merged 1 commit into from
Oct 11, 2020

Conversation

paulpach
Copy link
Contributor

Previously we initialized syncobjects, so this is valid:

public class Pepe : NetworkBehavior {

    public SyncList<int> mylist;
}

With this change, users must initialize their own fields:

public class Pepe : NetworkBehavior {

    public SyncList<int> mylist = new SyncList<int>();
}

BREAKING CHANGE: You must initialize all your SyncLists

Previously we initialized syncobjects, so this is valid:
```cs
public class Pepe : NetworkBehavior {

    public SyncList<int> mylist;
}
```

With this change,  users must initialize their own fields:
```cs
public class Pepe : NetworkBehavior {

    public SyncList<int> mylist = new SyncList<int>();
}
```

BREAKING CHANGE: You must initialize all your SyncLists
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@paulpach paulpach merged commit c0e2632 into master Oct 11, 2020
@paulpach paulpach deleted the initsyncobj branch October 11, 2020 00:00
github-actions bot pushed a commit that referenced this pull request Oct 11, 2020
# [48.0.0](v47.0.3...v48.0.0) (2020-10-11)

* Users must initialize syncobjects (#391) ([c0e2632](c0e2632)), closes [#391](#391)

### BREAKING CHANGES

* You must initialize all your SyncLists
@github-actions
Copy link
Contributor

🎉 This PR is included in version 48.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants