feat: KCP transport now has CRC64 validation #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Sounds good. Note that you can completely disable the built-in CRC with |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 15, 2020
# [49.3.0](v49.2.0...v49.3.0) (2020-10-15) ### Bug Fixes * double counting packets on kcp receive ([89cb937](89cb937)) * NRE when disconnecting with no owned objects ([4e7983e](4e7983e)) ### Features * KCP transport now has CRC64 validation ([#397](#397)) ([21c8649](21c8649)) ### Performance Improvements * recycle segments ([13a3c3d](13a3c3d)) * reduce allocation sending to observers ([f5f7f6c](f5f7f6c)) * reduce allocations per client ([8d37f8c](8d37f8c)) * Refactore move to receive queue ([173735c](173735c)) * remove allocation ([9311fbd](9311fbd)) * reuse segment if it is a repeat ([4879010](4879010)) * Use allocation free completion source ([20227a7](20227a7)) * use Unitask ([384d02b](384d02b)) * Use UniTask instead of task ([70c9cfb](70c9cfb))
|
🎉 This PR is included in version 49.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every message now is verified with a CRC64 checksum.
This makes it practically immune to corruption.
Note that UDP has a CRC16 built-in, which does make it possible for corruption to go undetected.
The performance impact seems completely negligible.