breaking: ClientObjectManager #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uweeby
force-pushed
the
clientObjectManager
branch
from
c101792
to
c01bab1
Compare
uweeby
force-pushed
the
clientObjectManager
branch
from
f06a006
to
6609063
Compare
uweeby
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
paulpach
pushed a commit
that referenced
this pull request
Oct 29, 2020
server side companion to #438. BREAKING CHANGE: NetworkServer no longer spawns objects, add a ServerObjectManager for that
|
🎉 This PR is included in version 56.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the cognitive complexity warning for the NetworkClient class. As you can see its serving a dual purpose of providing access to the Transport and Messaging but also full control of all object spawning. This creates some dependency layer overlap.
All tests passed locally. Verified with Tanks and ChangeScene example in Host and Client/Server mode.
Ignoring all of the scene and test LOC changes. This adds about 60 lines overall of basically boiler plate levels of code to make the new class function correctly with unity/mirror lifecycle.
There are no changes to how spawning functions. Its mostly a cut/paste into a new class. Then fix the wiring issues.
BREAKING CHANGE: NetworkClient no longer spawns objects, add a ClientObjectManager for that