Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log settings component #439

Merged
merged 13 commits into from
Oct 26, 2020
Merged

feat: log settings component #439

merged 13 commits into from
Oct 26, 2020

Conversation

paulpach
Copy link
Contributor

@paulpach paulpach commented Oct 26, 2020

Logger from Mirror is way over-engineered.

This can be done with a simple component in a gameobject.

image

@paulpach paulpach changed the title remove over engineered logger remove over engineered log settings Oct 26, 2020
@paulpach paulpach changed the title remove over engineered log settings feat: log settings component Oct 26, 2020
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@paulpach
Copy link
Contributor Author

Logger from Mirror is way over-engineered.

This can be done with a simple component in a gameobject.

image

@paulpach paulpach merged commit 9f06f2e into master Oct 26, 2020
@paulpach paulpach deleted the logger branch October 26, 2020 18:50
github-actions bot pushed a commit that referenced this pull request Oct 26, 2020
# [54.1.0](v54.0.0...v54.1.0) (2020-10-26)

### Features

* log settings component ([#439](#439)) ([9f06f2e](9f06f2e))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 54.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant