fix: better transport checks on NS and NC #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpach
requested changes
Nov 3, 2020
paulpach
approved these changes
Nov 3, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Lymdun
approved these changes
Nov 3, 2020
|
🎉 This PR is included in version 56.4.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On NC it was not actually setting the value of the comp found via GetComponent. That would cause the following try to throw an NRE when you tried to connect. Now it throws for the same reason but gives a specific line and reason in the debug message. Much easier to debug. The same logic was applied to the server side.