-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support legacy Weaver #546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new ILPostProcessor is having issue with rewired. This allows the weaver to work in legacy mode: that is using the hooks. to use it, add LEGACY_ILPP to your defines
uweeby
approved these changes
Feb 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested with a known bad situation where weaver forces a rebuild all. this PR resolved the issue.
SonarCloud Quality Gate failed. |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 4, 2021
## [63.3.2](v63.3.1...v63.3.2) (2021-02-04) ### Bug Fixes * support legacy Weaver ([#546](#546)) ([e1bbc03](e1bbc03))
🎉 This PR is included in version 63.3.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new ILPostProcessor is having issue with rewired.
This allows the weaver to work in legacy mode: that is using the hooks.
to use it, add LEGACY_ILPP to your defines