feat: awaitable connect #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: ClientConnect replaced with ClientConnectAsync that can be awaited
|
Nice PR, but why did you modified ServerDisconnect too? |
Lymdun
requested changes
Feb 1, 2020
Lymdun
reviewed
Feb 6, 2020
…into asynctelepathy
|
Issues
======
+ Solved 6
- Added 25
Complexity increasing per file
==============================
- Assets/Mirror/Tests/Editor/Tcp/TcpTest.cs 3
- Assets/Mirror/Runtime/Transport/Tcp/Server.cs 1
- Assets/Mirror/Runtime/Transport/Telepathy/Client.cs 1
Complexity decreasing per file
==============================
+ Assets/Mirror/Runtime/Transport/Tcp/Client.cs -1
+ Assets/Mirror/Examples/ListServer/ListServer.cs -1
Clones added
============
- Assets/Mirror/Runtime/Transport/Tcp/TcpTransport.cs 1
- Assets/Mirror/Tests/Editor/Tcp/TcpTest.cs 8
- Assets/Mirror/Tests/Editor/Telepathy/TransportTest.cs 4
- Assets/Mirror/Runtime/Transport/TelepathyTransport.cs 1
Clones removed
==============
+ Assets/Mirror/Tests/Editor/FallbackTransportTest.cs -1
+ Assets/Mirror/Tests/Editor/MultiplexTest.cs -1
+ Assets/Mirror/Tests/Editor/FallbackTest.cs -1
See the complete overview on Codacy |
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions bot
pushed a commit
that referenced
this pull request
Feb 8, 2020
# [9.0.0](8.0.1-master...9.0.0-master) (2020-02-08) ### Bug Fixes * don't report error when stopping the server ([c965d4b](c965d4b)) ### Features * awaitable connect ([#55](#55)) ([952e8a4](952e8a4)) ### BREAKING CHANGES * ClientConnect replaced with ClientConnectAsync that can be awaited * fix: TCP transport for async compliance * use async connect * Ignore telepathy tests until they are fixed * It is ok to interrupt sockets * Remove some warnings * Remove some warnings * Remove some warnings * Remove some warnings * Remove some warnings * Remove some warnings * Remove some warnings
github-actions bot
pushed a commit
that referenced
this pull request
Feb 8, 2020
* Asynchronous transport connect * Implement needed interface * feat: you can now await transport connect BREAKING CHANGE: ClientConnect replaced with ClientConnectAsync that can be awaited * fix: TCP transport for async compliance * use async connect * Ignore telepathy tests until they are fixed * It is ok to interrupt sockets * Remove some warnings * Remove some warnings * Remove some warnings * Remove some warnings * Remove some warnings * Remove some warnings * Remove some warnings
github-actions bot
pushed a commit
that referenced
this pull request
Feb 8, 2020
# [9.0.0](8.0.1-master...9.0.0-master) (2020-02-08) ### Bug Fixes * don't report error when stopping the server ([c965d4b](c965d4b)) ### Features * awaitable connect ([#55](#55)) ([952e8a4](952e8a4)) ### BREAKING CHANGES * ClientConnect replaced with ClientConnectAsync that can be awaited * fix: TCP transport for async compliance * use async connect * Ignore telepathy tests until they are fixed * It is ok to interrupt sockets * Remove some warnings * Remove some warnings * Remove some warnings * Remove some warnings * Remove some warnings * Remove some warnings * Remove some warnings
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now await for the transport client to connect. This makes it a lot easier to capture errors and know when the connection is established
BREAKING CHANGE: ConnectClient has been replaced by ConnectClientAsync