Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: explicit declaration of network messages #565

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Conversation

paulpach
Copy link
Contributor

@paulpach paulpach commented Feb 3, 2021

Normally MirrorNG detects what is a message and creates an id for it.
This PR allows you to explicitly declare a class or struct as a network message
This can be useful when you are making a generic class (such as Discovery)

to explicitly mark a class/struct as a network message you can do:

[NetworkMessage]
public struct MyMessage {
...
}

Normally MirrorNG detects what is a message and creates an id for it.
This PR allows you to explicitly declare a class or struct as a network message
This can be useful when you are making a generic class (such as Discovery)
@paulpach paulpach changed the title feat: Explicit declaration of network messages feat: explicit declaration of network messages Feb 3, 2021
@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@paulpach paulpach merged commit b0610e2 into master Feb 3, 2021
@paulpach paulpach deleted the explictnm branch February 3, 2021 18:40
github-actions bot pushed a commit that referenced this pull request Feb 3, 2021
# [63.3.0](v63.2.1...v63.3.0) (2021-02-03)

### Bug Fixes

* remove last start call ([b8fc97d](b8fc97d))

### Features

* explicit declaration of network messages ([#565](#565)) ([b0610e2](b0610e2))
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2021

🎉 This PR is included in version 63.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant