Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: open changelog page when user downloaded a new version #571

Merged
merged 7 commits into from
Feb 9, 2021
Merged

feat: open changelog page when user downloaded a new version #571

merged 7 commits into from
Feb 9, 2021

Conversation

erikas-taroza
Copy link
Collaborator

Updated UI and added function to open to change log if the user downloaded a new version.

@erikas-taroza
Update welcome window to match PR on Mirror. Updated UI and added fun…
5437aca 
…ction to open to change log if the user downloaded a new version.
@erikas-taroza
Copy link
Collaborator Author

Please test if you are able to open up to the change log window after the version has been changed.
You can test by editing the GetVersion() method to return a different string.

@Lymdun Lymdun added enhancement New feature or request good first issue Good for newcomers labels Feb 7, 2021
@Lymdun Lymdun changed the title Update welcome window to match PR on Mirror. feat: Open changelog page when user downloaded a new version Feb 7, 2021
@Lymdun Lymdun changed the title feat: Open changelog page when user downloaded a new version feat: open changelog page when user downloaded a new version Feb 7, 2021
@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@erikas-taroza
Copy link
Collaborator Author

@Lymdun Please test if the welcome window does the following:

  1. Open to changelog if there is a new version.
  2. After closing, reopening should bring you to the welcome page and not show Change Log (updated) in the change log page.
  3. First time opening (change firstTimeMirrorKey key) brings you to the welcome page.

@Lymdun Lymdun merged commit d9ed96e into master Feb 9, 2021
@erikas-taroza erikas-taroza deleted the update-welcome-window branch February 9, 2021 22:42
github-actions bot pushed a commit that referenced this pull request Feb 9, 2021
@semantic-release-bot
chore(release): 63.4.0 [skip ci]
25e8f0f 
# [63.4.0](v63.3.5...v63.4.0) (2021-02-09)

### Features

* open changelog page when user downloaded a new version ([#571](#571)) ([d9ed96e](d9ed96e))
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2021

🎉 This PR is included in version 63.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lymdun Lymdun Lymdun approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers Needs testing released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erikas-taroza @Lymdun