refactor: readers no longer depends on NetworkClient and NetworkServer #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpach
changed the title
…kServer NetworkReader no longer has a hard coded dependency on NetworkClient and NetworkServer. rather the NetworkReader has an IObjectLocator, which can be any class that can find objects by netid. BREAKING CHANGE: NetworkReader no longer have .Client and .Server, it has a .ObjectLocator instead
|
SonarCloud Quality Gate failed. |
James-Frowen
approved these changes
Feb 14, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Feb 14, 2021
# [65.0.0](v64.0.0...v65.0.0) (2021-02-14) ### Code Refactoring * NetworkReader no longer depends on NetworkClient and NetworkServer ([15f27c4](15f27c4)) * readers no longer depends on NetworkClient and NetworkServer ([#583](#583)) ([177c307](177c307)) ### BREAKING CHANGES * NetworkReader no longer have .Client and .Server, it has a .ObjectLocator instead * NetworkReader no longer have .Client and .Server, it has a .ObjectLocator instead
|
🎉 This PR is included in version 65.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetworkReader no longer has a hardcoded dependency on NetworkClient and NetworkServer.
rather the NetworkReader has an IObjectLocator, which can be any class
that can find objects by netid.
BREAKING CHANGE: NetworkReader no longer have .Client and .Server, it has a .ObjectLocator instead