feat: optional dontdestroyonload for networkscenemanager #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Frowen
approved these changes
Feb 16, 2021
|
SonarCloud Quality Gate failed. |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2021
# [66.1.0](v66.0.0...v66.1.0) (2021-02-17) ### Features * optional dontdestroyonload for networkscenemanager ([#596](#596)) ([67e41bd](67e41bd))
|
🎉 This PR is included in version 66.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #587.
Without cutting any deeper I am ok with adding the option but defaulting it to enabled for now. I still think the current behavior is what most people would use. If not its a simple check box to change it :)
!!!NOTE: If you disable the DDOL setting for NetworkSceneManager and do a Normal (non additive) scene change you will need to take extra steps to ensure your Network containing GameObject is not destroyed in that operation!!!