Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new socket layer #749

Merged
merged 85 commits into from
Apr 20, 2021
Merged

feat: new socket layer #749

merged 85 commits into from
Apr 20, 2021

Conversation

James-Frowen
Copy link
Member

@James-Frowen James-Frowen commented Mar 30, 2021 •
edited

Peer isn't completely finished by it is ready enough to be merged so that we can start integrating it into mirage in other PR.

This PR is not breaking, but future PR that replace old transport with Peer will be.

Todo:

  • Send notify
  • Send Reliable
  • Pool buffer
  • handle invalid packets

Future:

  • multithread support
  • validate new connections
    • key/phrase
    • hashcash

Resources:

@James-Frowen James-Frowen added this to In progress in Architecture Rewrite via automation Mar 30, 2021
@James-Frowen James-Frowen mentioned this pull request Mar 30, 2021
Closed
13 tasks
@James-Frowen James-Frowen marked this pull request as draft March 30, 2021 00:54
@James-Frowen James-Frowen changed the title new socket layer feat: new socket layer Apr 13, 2021
@James-Frowen
Copy link
Member Author

James-Frowen commented Apr 14, 2021 •
edited

  • remove BatchSendQueue
  • remove PeerUpdater
  • split up acksystem.cs
  • doc comments for Connection.cs
  • move connection state to enums? or split up enums
  • IDataHandler rename to receive packet
    • document what a packet is
  • ISocket fix doc comment
  • ISocket add doc comment for close
  • is packet.cs worth it?
  • improve comment in SocketCreator
  • unit test for bufferpool?
  • unit test for ConnectKeyValidator

@James-Frowen James-Frowen marked this pull request as ready for review April 16, 2021 01:13
@James-Frowen James-Frowen mentioned this pull request Apr 16, 2021
Merged
6 tasks
@James-Frowen
marking bytebuffer as sealed
6de1941
@James-Frowen
cleaning some code smells in ack system
411543f
@James-Frowen
fixing compile errors and adding to config
eda6dae
@James-Frowen
docs and fixing code smells in buffer pool
95b70ae
@James-Frowen
fixing compile error in test
4aeff42
@James-Frowen
code smells in connect
fbda8ed
@James-Frowen
replacing exception with tood
b064d8b
@James-Frowen
peer code smells
461ad6a
@James-Frowen
fixing code smells in udp creator
c967380
@James-Frowen
test for dropped packets
81e9dfd
@James-Frowen
simplifying ack code
fe11996
@James-Frowen
removing referecnce
c974dd8 
should be added in different PR
@James-Frowen
fixing notify send, cleaning by receive
23c4f8d
@James-Frowen
adding notify ack
81fe228 
empty packet that just has acks that is sent in cases where no other messages are sent recently
@James-Frowen
setting send time on construction
48db62b
@James-Frowen
fixing tests by creating copy of buffer
cc5ba6b
@James-Frowen
adding INotifyToken interface
3e789bc
@James-Frowen
adding Endpoint to IConnection
0ec383f
@James-Frowen
adding optional arguments to getEndpoint
b9b50f9
@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2021

SonarCloud Quality Gate failed.

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 28 Code Smells

68.1% 68.1% Coverage
1.2% 1.2% Duplication

@James-Frowen James-Frowen merged commit fb84452 into master Apr 20, 2021
Architecture Rewrite automation moved this from In progress to Done Apr 20, 2021
@James-Frowen James-Frowen deleted the peer-1 branch April 20, 2021 15:25
github-actions bot pushed a commit that referenced this pull request Apr 20, 2021
@semantic-release-bot
chore(release): 88.1.0 [skip ci]
ae56c1e 
# [88.1.0](v88.0.0...v88.1.0) (2021-04-20)

### Features

* new socket layer ([#749](#749)) ([fb84452](fb84452))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 88.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phodoval phodoval phodoval left review comments

@Lymdun Lymdun Lymdun approved these changes

Assignees
No one assigned
Labels
ready for review released
Projects
Architecture Rewrite
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@James-Frowen @Lymdun @phodoval