feat: add NetworkManagerMode back to NetMan #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Frowen
reviewed
Apr 1, 2021
James-Frowen
reviewed
Apr 1, 2021
James-Frowen
reviewed
Apr 1, 2021
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| namespace Mirage | |||
| { | |||
| public enum NetworkManagerMode { Offline, ServerOnly, ClientOnly, Host } | |||
There was a problem hiding this comment.
We could use a flag enum for this, since Host is just Server+Client
There was a problem hiding this comment.
I think it would be easier to work with as is
There was a problem hiding this comment.
or we can revisit in a different PR?
|
SonarCloud Quality Gate failed. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 8, 2021
# [87.1.0](v87.0.1...v87.1.0) (2021-04-08) ### Features * add NetworkManagerMode back to NetMan ([#756](#756)) ([f1f8f57](f1f8f57))
|
🎉 This PR is included in version 87.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dragonslaya84
pushed a commit
that referenced
this pull request
Apr 11, 2021
* feat: add NetworkManagerMode back to NetMan * fix formatting * remove only suffix * add flags * code smell * rename and add test * add test
dragonslaya84
pushed a commit
that referenced
this pull request
Apr 11, 2021
# [87.1.0](v87.0.1...v87.1.0) (2021-04-08) ### Features * add NetworkManagerMode back to NetMan ([#756](#756)) ([f1f8f57](f1f8f57))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves part of the issue for: #740