fix: using AddLateEvent to stop race condition for client events #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Frowen
force-pushed
the
addLateEvent6
branch
from
0c352ff
to
b593375
Compare
|
SonarCloud Quality Gate failed. |
uweeby
approved these changes
Apr 7, 2021
public event now uses IAddLateEvent, this should not effect how existing events are added via code. BREAKING CHANGE: - NetworkClient.Connected event is now type of IAddLateEvent - NetworkClient.Authenticated event is now type of IAddLateEvent - NetworkClient.Disconnected event is now type of IAddLateEvent
BREAKING CHANGE: NetworkConnectionEvent renamed to NetworkPlayerEvent
James-Frowen
force-pushed
the
addLateEvent6
branch
from
2678192
to
9474c92
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Apr 8, 2021
# [87.0.0](v86.0.2...v87.0.0) (2021-04-08) ### Bug Fixes * using add late event for authority and combining start and stop events ([#767](#767)) ([8903f00](8903f00)) * using AddLateEvent to stop race condition for client events ([#768](#768)) ([681875b](681875b)) * using AddLateEvent to stop race condition for network identity events ([#766](#766)) ([4f8bf11](4f8bf11)) * using AddLateEvent to stop race condition for server events ([#765](#765)) ([a1ec84c](a1ec84c)) ### Features * adding RemoveListener and RemoveAllListeners to AddLateEvent ([#764](#764)) ([d67c96c](d67c96c)) * adding RemoveListener and RemoveAllListeners to AddLateEvent ([#764](#764)) ([0ca2804](0ca2804)) ### BREAKING CHANGES * - NetworkClient.Connected event is now type of IAddLateEvent - NetworkClient.Authenticated event is now type of IAddLateEvent - NetworkClient.Disconnected event is now type of IAddLateEvent * refactor: removing NetworkConnectionEvent use NetworkPlayerEvent instead * NetworkConnectionEvent renamed to NetworkPlayerEvent * reverting clean up change * - Identity.OnStartAuthority and IdentityOnStopAuthority are now Identity.OnAuthorityChanged and are type of IAddLateEvent<bool> * - Server.Started event is now type of IAddLateEvent - Server.Stoped event is now type of IAddLateEvent - Server.OnStartHost event is now type of IAddLateEvent - Server.OnStopHost event is now type of IAddLateEvent - inspector values for changed events will need to be re-assigned * - Identity.OnStartServer event is now type of IAddLateEvent - Identity.OnStopServer event is now type of IAddLateEvent - Identity.OnStartClient event is now type of IAddLateEvent - Identity.OnStopClient event is now type of IAddLateEvent - Identity.OnStartLocalPlayer event is now type of IAddLateEvent - inspector values for changed events will need to be re-assigned * AddLateEvent Reset no longer removes listeners * AddLateEvent Reset no longer removes listeners
|
🎉 This PR is included in version 87.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dragonslaya84
pushed a commit
that referenced
this pull request
Apr 11, 2021
* feat: adding AddLate event for NetworkPlayer * fix: using AddLateEvent to stop race condition for client events public event now uses IAddLateEvent, this should not effect how existing events are added via code. BREAKING CHANGE: - NetworkClient.Connected event is now type of IAddLateEvent - NetworkClient.Authenticated event is now type of IAddLateEvent - NetworkClient.Disconnected event is now type of IAddLateEvent * refactor: removing NetworkConnectionEvent use NetworkPlayerEvent instead BREAKING CHANGE: NetworkConnectionEvent renamed to NetworkPlayerEvent * reverting clean up change
dragonslaya84
pushed a commit
that referenced
this pull request
Apr 11, 2021
# [87.0.0](v86.0.2...v87.0.0) (2021-04-08) ### Bug Fixes * using add late event for authority and combining start and stop events ([#767](#767)) ([8903f00](8903f00)) * using AddLateEvent to stop race condition for client events ([#768](#768)) ([681875b](681875b)) * using AddLateEvent to stop race condition for network identity events ([#766](#766)) ([4f8bf11](4f8bf11)) * using AddLateEvent to stop race condition for server events ([#765](#765)) ([a1ec84c](a1ec84c)) ### Features * adding RemoveListener and RemoveAllListeners to AddLateEvent ([#764](#764)) ([d67c96c](d67c96c)) * adding RemoveListener and RemoveAllListeners to AddLateEvent ([#764](#764)) ([0ca2804](0ca2804)) ### BREAKING CHANGES * - NetworkClient.Connected event is now type of IAddLateEvent - NetworkClient.Authenticated event is now type of IAddLateEvent - NetworkClient.Disconnected event is now type of IAddLateEvent * refactor: removing NetworkConnectionEvent use NetworkPlayerEvent instead * NetworkConnectionEvent renamed to NetworkPlayerEvent * reverting clean up change * - Identity.OnStartAuthority and IdentityOnStopAuthority are now Identity.OnAuthorityChanged and are type of IAddLateEvent<bool> * - Server.Started event is now type of IAddLateEvent - Server.Stoped event is now type of IAddLateEvent - Server.OnStartHost event is now type of IAddLateEvent - Server.OnStopHost event is now type of IAddLateEvent - inspector values for changed events will need to be re-assigned * - Identity.OnStartServer event is now type of IAddLateEvent - Identity.OnStopServer event is now type of IAddLateEvent - Identity.OnStartClient event is now type of IAddLateEvent - Identity.OnStopClient event is now type of IAddLateEvent - Identity.OnStartLocalPlayer event is now type of IAddLateEvent - inspector values for changed events will need to be re-assigned * AddLateEvent Reset no longer removes listeners * AddLateEvent Reset no longer removes listeners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires: #764
public event now uses IAddLateEvent, this should not effect how existing events are added via code.
BREAKING CHANGE: