refactor: renaming network server disconnect to stop #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disconnect is not an intuitive name for a method that stops or closes the server. BREAKING CHANGE: NetworkServer.Disconnect is now called Stop
James-Frowen
force-pushed
the
rename-server-functions
branch
from
d9c9117
to
608b284
Compare
uweeby
approved these changes
Apr 28, 2021
|
Kudos, SonarCloud Quality Gate passed! |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 28, 2021
# [89.0.0](v88.1.3...v89.0.0) (2021-04-28) ### Code Refactoring * renaming network server disconnect to stop ([#793](#793)) ([634139c](634139c)) ### BREAKING CHANGES * NetworkServer.Disconnect is now called Stop
|
🎉 This PR is included in version 89.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disconnect is not an intuitive name for a method that stops or closes the server.
BREAKING CHANGE: NetworkServer.Disconnect is now called Stop