Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to resolve reference System.Private.Uri on Unity 2021.1.6f1 with v91.2.0 #804

Closed
ryo0ka opened this issue May 18, 2021 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@ryo0ka
Copy link

ryo0ka commented May 18, 2021

Describe the bug
Installing Mirage package v91.2.0 on Unity 2021.1.6f1 yields 3 errors regarding a missing library System.Private.Uri. Samples run in a broken state due to missing scripts.

Repro project
https://github.com/Kijibizi/MirageTest

To Reproduce
Steps to reproduce the behavior:

  1. Make a new Unity project on 2021.1.6f1
  2. Follow instruction on README and install Mirage
  3. See logs on console

Expected behavior
Package succeeds to install & samples run properly

Screenshots
image
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Build target: Standalone
  • Unity version: 2021.1.6f1
  • Mirage version: v91.2.0
@ryo0ka
Copy link
Author

ryo0ka commented May 18, 2021

Reproduced with v84.1.1 and onward

Prior to v84.1.1, package won't compile due to NullReferenceException:

image

In other words none of package versions works

@Lymdun
Copy link
Member

Lymdun commented May 18, 2021

For a bit more of context, this issue is caused by a change from ILPP on 2021.1+ which is used by the weaver. It is using mono cecil, it adds a reference to System.Private.Uri.dll when saving the dll, that is not on the editor. Further investigation is required to see how to become compatible with latest ILPP version (and thus, editor 2021.1+). For now, Mirage supports up to Unity 2020.3.

@ryo0ka
Copy link
Author

ryo0ka commented May 19, 2021

sounds good, thanks for the quick response cheers

@ryo0ka ryo0ka closed this as completed May 19, 2021
@Lymdun
Copy link
Member

Lymdun commented May 19, 2021

Re-opening it, since it's an issue we'll need to address anytime soon

@Lymdun Lymdun reopened this May 19, 2021
@James-Frowen James-Frowen added the bug Something isn't working label May 19, 2021
@James-Frowen
Copy link
Member

fixed by: #811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants