Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: replacing network writer with a faster version that can do bit packing #805

Merged
merged 56 commits into from
Jul 2, 2021

Conversation

James-Frowen
Copy link
Member

@James-Frowen James-Frowen commented May 23, 2021

BREAKING: NetworkWriter and NetworkReader have been completely re-written to support bitpacking

@vladqwerty435
Copy link

OOOH

@Lymdun Lymdun changed the title pref: replacing network writer with a faster version that can do bit packing perf: replacing network writer with a faster version that can do bit packing Jun 4, 2021
@James-Frowen James-Frowen removed the has conflicts Pull Request has merge conflicts label Jun 17, 2021
@James-Frowen James-Frowen marked this pull request as ready for review June 20, 2021 13:23
@github-actions github-actions bot added the has conflicts Pull Request has merge conflicts label Jun 20, 2021
@James-Frowen James-Frowen removed the has conflicts Pull Request has merge conflicts label Jun 21, 2021
@github-actions github-actions bot added the has conflicts Pull Request has merge conflicts label Jun 23, 2021
@James-Frowen James-Frowen removed the has conflicts Pull Request has merge conflicts label Jun 23, 2021
@github-actions github-actions bot added the has conflicts Pull Request has merge conflicts label Jun 23, 2021
@James-Frowen James-Frowen force-pushed the bit-writer branch 3 times, most recently from f7b66b9 to 5a99513 Compare July 1, 2021 22:23
@James-Frowen James-Frowen removed the has conflicts Pull Request has merge conflicts label Jul 1, 2021
@github-actions github-actions bot added the has conflicts Pull Request has merge conflicts label Jul 2, 2021
- re-adding static classes to help with pool
- marking NetworkDiagnostics as Obsolete for now, will be added back in later or merged with peer metrics
- allowing mirage to be unsafe
- moving generic writers to their own files
@sonarcloud
Copy link

sonarcloud bot commented Jul 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

88.8% 88.8% Coverage
0.0% 0.0% Duplication

@James-Frowen James-Frowen removed the has conflicts Pull Request has merge conflicts label Jul 2, 2021
@James-Frowen James-Frowen merged commit 773c58f into master Jul 2, 2021
@James-Frowen James-Frowen deleted the bit-writer branch July 2, 2021 20:06
github-actions bot pushed a commit that referenced this pull request Jul 2, 2021
## [98.0.1](v98.0.0...v98.0.1) (2021-07-02)

### Performance Improvements

* replacing network writer with a faster version that can do bit packing ([#805](#805)) ([773c58f](773c58f))
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

🎉 This PR is included in version 98.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

James-Frowen added a commit that referenced this pull request Jul 3, 2021
…packing (#805)

(empty commit for CI)

BREAKING CHANGE: NetworkWriter and NetworkReader have been completely re-written to support bitpacking
github-actions bot pushed a commit that referenced this pull request Jul 3, 2021
# [99.0.0](v98.0.1...v99.0.0) (2021-07-03)

### Performance Improvements

* replacing network writer with a faster version that can do bit packing ([#805](#805)) ([3cffa66](3cffa66))

### BREAKING CHANGES

* NetworkWriter and NetworkReader have been completely re-written to support bitpacking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants