-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: replacing network writer with a faster version that can do bit packing #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OOOH |
Lymdun
changed the title
pref: replacing network writer with a faster version that can do bit packing
perf: replacing network writer with a faster version that can do bit packing
Jun 4, 2021
1 task
Lymdun
reviewed
Jun 22, 2021
James-Frowen
commented
Jun 23, 2021
Lymdun
approved these changes
Jun 23, 2021
James-Frowen
force-pushed
the
bit-writer
branch
3 times, most recently
from
July 1, 2021 22:23
f7b66b9
to
5a99513
Compare
- re-adding static classes to help with pool - marking NetworkDiagnostics as Obsolete for now, will be added back in later or merged with peer metrics - allowing mirage to be unsafe - moving generic writers to their own files
they will be removed when replacement is ready
Kudos, SonarCloud Quality Gate passed! |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 2, 2021
## [98.0.1](v98.0.0...v98.0.1) (2021-07-02) ### Performance Improvements * replacing network writer with a faster version that can do bit packing ([#805](#805)) ([773c58f](773c58f))
🎉 This PR is included in version 98.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
James-Frowen
added a commit
that referenced
this pull request
Jul 3, 2021
…packing (#805) (empty commit for CI) BREAKING CHANGE: NetworkWriter and NetworkReader have been completely re-written to support bitpacking
github-actions bot
pushed a commit
that referenced
this pull request
Jul 3, 2021
# [99.0.0](v98.0.1...v99.0.0) (2021-07-03) ### Performance Improvements * replacing network writer with a faster version that can do bit packing ([#805](#805)) ([3cffa66](3cffa66)) ### BREAKING CHANGES * NetworkWriter and NetworkReader have been completely re-written to support bitpacking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING: NetworkWriter and NetworkReader have been completely re-written to support bitpacking