feat: adding started event to client #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This event can be useful to do things before connected. This along with message handler #818 will fix the host mode message issues. Call order for hostMode - Server.Start - Client.Start - Client.Connected and Client.Authenticated - Server.Connected and Server.Authenticated call order of Connected vs Authenticated will be inconsistent because Authenticated is called by Connected so couldd be inbetween Connected event calls
James-Frowen
force-pushed
the
clientStartEvent
branch
from
63e402b
to
94e29d3
Compare
|
Kudos, SonarCloud Quality Gate passed! |
github-actions bot
pushed a commit
that referenced
this pull request
May 29, 2021
# [95.1.0](v95.0.0...v95.1.0) (2021-05-29) ### Features * adding started event to client ([#825](#825)) ([3360b7c](3360b7c))
|
🎉 This PR is included in version 95.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires: #821
This event can be useful to do things before connected. This along with message handler #818 will fix the host mode message issues.
Call order for hostMode
Call order of Connected vs Authenticated will be inconsistent because Authenticated is called by Connected so couldd be inbetween Connected event calls