WIP: merge clientscene and networkclient #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpach
reviewed
Mar 19, 2020
| @@ -152,7 +152,7 @@ void SendAnimationMessage(int stateHash, float normalizedTime, int layerId, byte | |||
| { | |||
| RpcOnAnimationClientMessage(stateHash, normalizedTime, layerId, parameters); | |||
| } | |||
| else if (ClientScene.readyConnection != null) | |||
| else if (client.connection != null) | |||
There was a problem hiding this comment.
This is so much better!
We could even merge this without the rest of the stuff.
This is not a problem in UPM
We already have NetworkClient.hostServer for this exact purpose
unspawning an object is now consistent between DestroyObject and DestroyAllObjects by refactoring into Unspawn method
|
Issues
======
+ Solved 1
- Added 5
Complexity increasing per file
==============================
- Assets/Mirror/Runtime/NetworkClient.cs 3
See the complete overview on Codacy |
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions bot
pushed a commit
that referenced
this pull request
Mar 20, 2020
# [20.0.0](19.1.2-master...20.0.0-master) (2020-03-20) ### Bug Fixes * compilation issue after merge from mirror ([daf07be](daf07be)) * merge clientscene and networkclient (#84) ([dee1046](dee1046)), closes [#84](#84) ### Features * SyncSet and SyncDictionary now show in inspector ([#1561](https://github.com/MirrorNG/MirrorNG/issues/1561)) ([5510711](5510711)) ### BREAKING CHANGES * ClientScene is gone
github-actions bot
pushed a commit
that referenced
this pull request
Mar 20, 2020
Merge clientScene and NetworkClient, getting rid of all that static state. BREAKING CHANGE: ClientScene is gone
github-actions bot
pushed a commit
that referenced
this pull request
Mar 20, 2020
# [20.0.0](19.1.2-master...20.0.0-master) (2020-03-20) ### Bug Fixes * compilation issue after merge from mirror ([daf07be](daf07be)) * merge clientscene and networkclient (#84) ([dee1046](dee1046)), closes [#84](#84) ### Features * SyncSet and SyncDictionary now show in inspector ([#1561](https://github.com/MirrorNG/MirrorNG/issues/1561)) ([5510711](5510711)) ### BREAKING CHANGES * ClientScene is gone
|
🎉 This PR is included in version 20.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.