Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: adding native UDP socket (NanoSockets) for supported platforms #860

Merged
merged 13 commits into from
Jul 16, 2021

Conversation

phodoval
Copy link
Contributor

No description provided.

@James-Frowen
Copy link
Member

test running here https://github.com/MirageNet/Mirage/runs/3079229937

Assets/Mirage/Runtime/Sockets/Udp/NanoSocket.cs Outdated Show resolved Hide resolved
Assets/Mirage/Runtime/Sockets/Udp/UdpSocketFactory.cs Outdated Show resolved Hide resolved
@@ -0,0 +1,222 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use git submodules instead than copying the file manually?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a submodule to the repo will probably require some CI tweaks to also fetch the sumbodules when checking out etc. The same would go for anyone who would want to clone the repo. Also not sure about UPM. I do use the git submodules personally but I must say it's quite tedious.

@James-Frowen James-Frowen merged commit 3f34863 into MirageNet:master Jul 16, 2021
@phodoval phodoval deleted the feature/nanosockets branch July 17, 2021 09:51
github-actions bot pushed a commit that referenced this pull request Jul 19, 2021
## [100.0.1](v100.0.0...v100.0.1) (2021-07-19)

### Bug Fixes

* **NanoSocket:** adding Exception when nanosocket bind fails ([a3028ec](a3028ec))

### Performance Improvements

* adding native UDP socket (NanoSockets) for supported platforms ([#860](#860)) ([3f34863](3f34863))
* removing allocations from assert ([5c216de](5c216de))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 100.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants