Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow welcome window to display xx number of entries now #912

Merged
merged 6 commits into from
Sep 8, 2021

Conversation

dragonslaya84
Copy link
Member

Currently hard coded through welcome window script to 4 last change logs.

dragonslaya-ss and others added 5 commits June 19, 2021 10:37
fix: allow 2019 and up for welcome window.

Signed-off-by: dragonslaya <steve.s@bigredplanetgames.com>
Signed-off-by: dragonslaya <steve.s@bigredplanetgames.com>
…o know which mirage install was done.

Signed-off-by: dragonslaya <steve.s@bigredplanetgames.com>
…elog path.

fix: fixed code smells

Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
…Need to change it atm through code.

Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
…rom master now and fixed it all up again.

Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 3, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@James-Frowen
Copy link
Member

Seems to work, I dont know the uxml stuff tho so can't review that, so merge if you think its good

@dragonslaya84 dragonslaya84 merged commit 57223f9 into master Sep 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

🎉 This PR is included in version 103.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants