feat: (DONT SQUASH) adding event for when player has finished loading scene #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Frowen
force-pushed
the
player-ready
branch
3 times, most recently
from
68680da
to
a467e64
Compare
James-Frowen
changed the title
BREAKING CHANGE: NetworkPlayer.RemoveObservers renamed to RemoveAllVisibleObjects
BREAKING CHANGE: Renaming NotReadyMessage to SceneNotReadyMessage
BREAKING CHANGE: Removing ReadyMessage, Use SceneReadyMessage instead
BREAKING CHANGE: Renaming SceneObjectManager.SetClientReady to SpawnVisibleObjects
BREAKING CHANGE: moving SetAllClientsNotReady and SetClientNotReady from ServerObjectManager to NetworkSceneManager
Adding event that is called when a client replies with Scene Ready
James-Frowen
force-pushed
the
player-ready
branch
from
d8c4cdf
to
a7dc352
Compare
adding property that checks if Identity is set on networkplayer
Would throw null ref is previousCharacter was null. now throw InvalidOperationException with helpful message instead
When a player first connects it is now assumed that they are in a ready scene. NetworkSceneManager will set them to not ready if it has any scenes to load. Spawning Visible objects will still wait for a character to be added before spawning. BREAKING CHANGE: NetworkPlayer.SceneIsReady now default to true
BREAKING CHANGE: NetworkServerManager.OnServerAuthenticated is now protected instead of public
James-Frowen
force-pushed
the
player-ready
branch
from
a7dc352
to
9234eb4
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
🎉 This PR is included in version 104.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: