perf(Weaver): adding module import cache to save references #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Frowen
force-pushed
the
perf-import-cache
branch
from
fcec070
to
51aa494
Compare
James-Frowen
force-pushed
the
perf-import-cache
branch
from
51aa494
to
87fb7af
Compare
James-Frowen
force-pushed
the
perf-import-cache
branch
from
87fb7af
to
a5ddc8c
Compare
James-Frowen
force-pushed
the
perf-import-cache
branch
from
955b5e9
to
3338675
Compare
…ng every instruction
dont need sub function for this, it just confuses the flow
methods that are called first go above ones they call
we are already checking all types for some attributes, might as well check all types for them
it should be fine to search for Generic Send calls after everything else. if they are used else where we will just generate writer for them there instead of in this loop
James-Frowen
force-pushed
the
perf-import-cache
branch
from
3338675
to
c10c2b0
Compare
|
Closing because big improvements have already been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.