fix: character spawner fix #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… during scene loads this wont ever register again. Need to change it on scene changes. Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
| @@ -100,6 +91,15 @@ private void OnServerStarted() | |||
| /// <param name="sceneOperation">The type of scene load that happened.</param> | |||
| public virtual void OnClientFinishedSceneChange(string scenePath, SceneOperation sceneOperation) | |||
| { | |||
| if (ClientObjectManager != null) | |||
| { | |||
| ClientObjectManager.RegisterPrefab(PlayerPrefab); | |||
There was a problem hiding this comment.
I think this would register the prefab multiple times, Might be better to register it once when the client starts
There was a problem hiding this comment.
It currently registers everytime scene changes. Mirage itself calls register prefabs internally in clientobjectmanager. This is why i had to move this here. So we either need to change how mirage registers to once in clientobjectmanager or we need to do this. I trace it and every time player bit join then disconnect and join it called register spawn in that class
Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
Co-authored-by: James Frowen <jamesfrowendev@gmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
|
🎉 This PR is included in version 105.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
character spawner was registering the player prefab in awake an during scene loads this wont ever register again. Need to change it on scene changes.
Fixes #945
Signed-off-by: dragonslaya dragonslaya.ss@gmail.com