Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Dont squash) fixing asset id errors #985

Merged
merged 11 commits into from
Nov 7, 2021
Merged

(Dont squash) fixing asset id errors #985

merged 11 commits into from
Nov 7, 2021

Conversation

James-Frowen
Copy link
Member

No description provided.

…nction

Unity uses the Reset method when doing right click reset. If we override it then we can't reset the ids manually if something goes wrong
BREAKING CHANGE: Scene Id generation is no longer public
Mirage will never need both scene id and prefab hash, so we never need to send both of them.

also using new networkidentity helper properties else where too

BREAKING CHANGE: Scene objects based on a prefab will no longer have their PrefabHash set on spawn on the client
@sonarcloud
Copy link

sonarcloud bot commented Nov 6, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

79.1% 79.1% Coverage
0.0% 0.0% Duplication

@James-Frowen James-Frowen merged commit 858150d into master Nov 7, 2021
@James-Frowen James-Frowen deleted the fix-id branch November 7, 2021 15:05
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2021

🎉 This PR is included in version 112.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant