Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban list reason error #22

Closed
mcjoshea opened this issue Sep 21, 2020 · 2 comments
Closed

Ban list reason error #22

mcjoshea opened this issue Sep 21, 2020 · 2 comments
Assignees
Labels

Comments

@mcjoshea
Copy link

mcjoshea commented Sep 21, 2020

After updating my node to Satoshi:0.20.1 I am now getting an error at the top of the page.

Notice: Undefined index: ban_reason in /var/www/bitcoin/bnm/src/Content.php on line 72

The ban list for rules I have setup myself now shows the reason for my bans as "unknown"

image

If I clear out the ban list, the warning at the top of the screen goes away.

I think this may be related to the recent update and the changes regarding misbehavnig peers.

https://bitcoin.org/en/release/v0.20.1#changes-regarding-misbehaving-peers

There is no method to list discouraged addresses. They are not returned by the listbanned RPC. That RPC also no longer reports the ban_reason field, as "manually added" is the only remaining option.

@Mirobit Mirobit added the Bug label Sep 22, 2020
@Mirobit Mirobit self-assigned this Sep 22, 2020
@Mirobit
Copy link
Owner

Mirobit commented Sep 22, 2020

Thanks for reporting and finding the change that caused the issue. I will fix this as soon as possible.

@Mirobit
Copy link
Owner

Mirobit commented Oct 26, 2020

I removed all information regarding the ban reason. Since Bitcoin core got rid of the auto ban feature, the BNM ban feature is even more useful.

@Mirobit Mirobit closed this as completed Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants