feat: asynchronous transport (#134)

Replaced Transport with AsyncTransport, Gets rid of transport singleton Gets rid of connectionId BREAKING CHANGE: connecition Id is gone BREAKING CHANGE: websocket transport does not work, needs to be replaced.
MirageNet · Apr 1, 2020 · 0e84f45 · 0e84f45
1 parent 3a19e3a
commit 0e84f45
Show file tree

Hide file tree

Showing 33 changed files with 805 additions and 1,437 deletions.
diff --git a/Assets/Mirror/Components/Discovery/NetworkDiscovery.cs b/Assets/Mirror/Components/Discovery/NetworkDiscovery.cs
@@ -17,7 +17,7 @@ public class NetworkDiscovery : NetworkDiscoveryBase<ServerRequest, ServerRespon
         public long ServerId { get; private set; }
 
         [Tooltip("Transport to be advertised during discovery")]
-        public Transport transport;
+        public AsyncTransport transport;
 
         [Tooltip("Invoked when a server is found")]
         public ServerFoundUnityEvent OnServerFound;
@@ -26,12 +26,6 @@ public override void Start()
         {
             ServerId = RandomLong();
 
-            // active transport gets initialized in awake
-            // so make sure we set it here in Start()  (after awakes)
-            // Or just let the user assign it in the inspector
-            if (transport == null)
-                transport = Transport.activeTransport;
-
             base.Start();
         }
 

diff --git a/Assets/Mirror/Components/Discovery/NetworkDiscoveryBase.cs.meta b/Assets/Mirror/Components/Discovery/NetworkDiscoveryBase.cs.meta
diff --git a/Assets/Mirror/Examples/ListServer/ListServers.cs b/Assets/Mirror/Examples/ListServer/ListServers.cs
@@ -186,7 +186,7 @@ public static void BalancePrefabs(GameObject prefab, int amount, Transform paren
         void OnUI()
         {
             // only show while client not connected and server not started
-            if (!manager.isNetworkActive || IsConnecting())
+            if (!manager.IsNetworkActive || IsConnecting())
             {
                 mainPanel.SetActive(true);
 

diff --git a/Assets/Mirror/Runtime/LocalConnections.cs b/Assets/Mirror/Runtime/LocalConnections.cs
diff --git a/Assets/Mirror/Runtime/NetworkBehaviour.cs b/Assets/Mirror/Runtime/NetworkBehaviour.cs
@@ -231,7 +231,7 @@ protected void SendCommandInternal(Type invokeClass, string cmdName, NetworkWrit
                 payload = writer.ToArraySegment()
             };
 
-            Client.Connection.Send(message, channelId);
+            _ = Client.SendAsync(message, channelId);
         }
 
         /// <summary>