feat: default log level option (#1728)

Each class can specify default log levels when requesting the logger.
MirageNet · Apr 17, 2020 · 5c56adc · 5c56adc
1 parent 006021e
commit 5c56adc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/Assets/Mirror/Runtime/LogFactory.cs b/Assets/Mirror/Runtime/LogFactory.cs
@@ -7,27 +7,27 @@ public static class LogFactory
     {
         internal static readonly Dictionary<string, ILogger> loggers = new Dictionary<string, ILogger>();
 
-        public static ILogger GetLogger<T>()
+        public static ILogger GetLogger<T>(LogType defaultLogLevel = LogType.Warning)
         {
-            return GetLogger(typeof(T).Name);
+            return GetLogger(typeof(T).Name, defaultLogLevel);
         }
 
-        public static ILogger GetLogger(System.Type type)
+        public static ILogger GetLogger(System.Type type, LogType defaultLogLevel = LogType.Warning)
         {
-            return GetLogger(type.Name);
+            return GetLogger(type.Name, defaultLogLevel);
         }
 
-        public static ILogger GetLogger(string loggerName)
+        public static ILogger GetLogger(string loggerName, LogType defaultLogLevel = LogType.Warning)
         {
-            if (loggers.TryGetValue(loggerName, out ILogger logger ))
+            if (loggers.TryGetValue(loggerName, out ILogger logger))
             {
                 return logger;
             }
 
             logger = new Logger(Debug.unityLogger)
             {
                 // by default, log warnings and up
-                filterLogType = LogType.Warning
+                filterLogType = defaultLogLevel
             };
 
             loggers[loggerName] = logger;
@@ -50,4 +50,4 @@ public static void LogWarning(this ILogger logger, object message)
 
         public static bool LogEnabled(this ILogger logger) => logger.IsLogTypeAllowed(LogType.Log);
     }
-}
+}
diff --git a/Assets/Mirror/Tests/Editor/Weaver/WeaverTests.cs b/Assets/Mirror/Tests/Editor/Weaver/WeaverTests.cs
@@ -20,19 +20,19 @@ public void TestSetup()
     [Category("Weaver")]
     public abstract class WeaverTests
     {
-        public static readonly ILogger logger = LogFactory.GetLogger<WeaverTests>();
+        public static readonly ILogger logger = LogFactory.GetLogger<WeaverTests>(LogType.Exception);
 
         protected List<string> weaverErrors = new List<string>();
         void HandleWeaverError(string msg)
         {
-            logger.Log(msg);
+            logger.LogError(msg);
             weaverErrors.Add(msg);
         }
 
         protected List<string> weaverWarnings = new List<string>();
         void HandleWeaverWarning(string msg)
         {
-            logger.Log(msg);
+            logger.LogWarning(msg);
             weaverWarnings.Add(msg);
         }