fix: #640 InternalReplacePlayerForConnection calls SpawnObserversForC…

…onnection now too
MirageNet · Mar 24, 2019 · bdf12c8 · bdf12c8
1 parent a2d6317
commit bdf12c8
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/Assets/Mirror/Runtime/NetworkServer.cs b/Assets/Mirror/Runtime/NetworkServer.cs
@@ -686,6 +686,8 @@ public static bool AddPlayerForConnection(NetworkConnection conn, GameObject pla
             // add connection to observers AFTER the playerController was set.
             // by definition, there is nothing to observe if there is no player
             // controller.
+            //
+            // IMPORTANT: do this in AddPlayerForConnection & ReplacePlayerForConnection!
             SpawnObserversForConnection(conn);
 
             if (SetupLocalPlayerForConnection(conn, identity))
@@ -777,6 +779,13 @@ internal static bool InternalReplacePlayerForConnection(NetworkConnection conn,
 
             //NOTE: DONT set connection ready.
 
+            // add connection to observers AFTER the playerController was set.
+            // by definition, there is nothing to observe if there is no player
+            // controller.
+            //
+            // IMPORTANT: do this in AddPlayerForConnection & ReplacePlayerForConnection!
+            SpawnObserversForConnection(conn);
+
             if (LogFilter.Debug) Debug.Log("NetworkServer ReplacePlayer setup local");
 
             if (SetupLocalPlayerForConnection(conn, playerNetworkIdentity))