refactor: replacing MessagePacker.GetMessageType with property #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a IReadOnlyDictionary property instead of get function. This allows methods like TryGetValue to also be used BREAKING CHANGE: MessagePacker.GetMessageType replaced with property
James-Frowen
force-pushed
the
handler-no-throw
branch
from
b9904dc
to
67db21c
Compare
|
Kudos, SonarCloud Quality Gate passed! |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 31, 2021
# [114.0.0](v113.3.4...v114.0.0) (2021-12-31) ### Bug Fixes * **NetworkTime:** renaming PingFrequency to PingInterval ([b729cdc](b729cdc)) ### Code Refactoring * replacing MessagePacker.GetMessageType with property ([#1016](#1016)) ([106c47c](106c47c)) ### BREAKING CHANGES * MessagePacker.GetMessageType replaced with property * **NetworkTime:** NetworkTime PingFrequency remamed to PingInterval
|
🎉 This PR is included in version 114.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a IReadOnlyDictionary property instead of get function. This allows methods like TryGetValue to also be used
BREAKING CHANGE: MessagePacker.GetMessageType replaced with property