Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: awaitable send and receive methods in NC and NS #134

Merged
merged 63 commits into from Apr 1, 2020

Conversation

paulpach
Copy link
Contributor

Switches to new AsyncTransport

BREAKING CHANGE: Connections no longer have a connection id

@paulpach paulpach force-pushed the asynctransport2 branch 3 times, most recently from ae65e32 to cc80b89 Compare March 31, 2020 13:08
Assets/Mirror/Runtime/NetworkManager.cs Outdated Show resolved Hide resolved
Assets/Mirror/Runtime/NetworkManager.cs Outdated Show resolved Hide resolved
Assets/Mirror/Runtime/NetworkManager.cs Outdated Show resolved Hide resolved
Assets/Mirror/Runtime/NetworkManager.cs Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@paulpach paulpach merged commit 0e84f45 into master Apr 1, 2020
@paulpach paulpach deleted the asynctransport2 branch April 1, 2020 01:14
github-actions bot pushed a commit that referenced this pull request Apr 1, 2020
# [31.0.0](30.3.3-master...31.0.0-master) (2020-04-01)

### Bug Fixes

* chat example ([e6e10a7](e6e10a7))
* missing meta ([87ace4d](87ace4d))

### Features

* asynchronous transport ([#134](#134)) ([0e84f45](0e84f45))

### BREAKING CHANGES

* connecition Id is gone
* websocket transport does not work,  needs to be replaced.
github-actions bot pushed a commit that referenced this pull request Apr 1, 2020
Replaced Transport with AsyncTransport,  
Gets rid of transport singleton
Gets rid of connectionId

BREAKING CHANGE: connecition Id is gone
BREAKING CHANGE: websocket transport does not work,  needs to be replaced.
github-actions bot pushed a commit that referenced this pull request Apr 1, 2020
# [31.0.0](30.3.3-master...31.0.0-master) (2020-04-01)

### Bug Fixes

* chat example ([e6e10a7](e6e10a7))
* missing meta ([87ace4d](87ace4d))

### Features

* asynchronous transport ([#134](#134)) ([0e84f45](0e84f45))

### BREAKING CHANGES

* connecition Id is gone
* websocket transport does not work,  needs to be replaced.
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2020

🎉 This PR is included in version 31.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants