feat: Server attribute now throws error #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you want to get an error you do this:
```cs
[Server]
public void ServerFunctionOnly() {}
```
If you don't want to get an error, you do this:
```cs
[Server(error = false)]
public void ServerFunctionOnly() {}
```
BREAKING CHANGE: [ServerCallback] is now [Server(error = false)]
Lymdun
approved these changes
Jul 13, 2020
|
SonarCloud Quality Gate failed.
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 13, 2020
# [37.0.0](36.0.0-master...37.0.0-master) (2020-07-13) ### Features * Server attribute now throws error ([#270](#270)) ([f3b5dc4](f3b5dc4)) ### BREAKING CHANGES * [ServerCallback] is now [Server(error = false)] * fixed weaver test * Remove unused code * fix comment * document replacement of ServerCallback * No need to be serializable * Exception should be serializable? * Fix code smell * No need to implement interface, parent does Co-authored-by: Paul Pacheco <paul.pacheco@aa.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2020
* feat: Server attribute now throws error
If you want to get an error you do this:
```cs
[Server]
public void ServerFunctionOnly() {}
```
If you don't want to get an error, you do this:
```cs
[Server(error = false)]
public void ServerFunctionOnly() {}
```
BREAKING CHANGE: [ServerCallback] is now [Server(error = false)]
* fixed weaver test
* Remove unused code
* fix comment
* document replacement of ServerCallback
* No need to be serializable
* Exception should be serializable?
* Fix code smell
* No need to implement interface, parent does
Co-authored-by: Paul Pacheco <paul.pacheco@aa.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2020
# [37.0.0](36.0.0-master...37.0.0-master) (2020-07-13) ### Features * Server attribute now throws error ([#270](#270)) ([f3b5dc4](f3b5dc4)) ### BREAKING CHANGES * [ServerCallback] is now [Server(error = false)] * fixed weaver test * Remove unused code * fix comment * document replacement of ServerCallback * No need to be serializable * Exception should be serializable? * Fix code smell * No need to implement interface, parent does Co-authored-by: Paul Pacheco <paul.pacheco@aa.com>
|
🎉 This PR is included in version 37.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to get an error you do this:
If you don't want to get an error, you do this:
BREAKING CHANGE: [ServerCallback] is now [Server(error = false)]