feat: You can use synclists directly #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you had to write a class that extended synclist to make the weaver happy:
```cs
class MyBehavior: NetworkBehaviour {
// nonsense to make the weaver happy
class SyncListMyType : SyncList<MyType> {}
public readonly SyncListMyType mylist = new SyncListMyType();
}
```
Now the weaver does not need to generate code for synclists anymore,
so you can use synclists as <insert your deity> intended:
```cs
class MyBehavior: NetworkBehaviour {
public readonly SyncList<MyType> mylist = new SyncList<MyType>();
}
```
BREAKING CHANGE: SyncList and other syncobjects no longer have override methods to serialize and deserialize data
paulpach
force-pushed
the
synclistnoweaver
branch
from
8180b2b
to
a625c01
Compare
|
SonarCloud Quality Gate failed.
|
paulpach
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2020
# [46.0.0](v45.0.1...v46.0.0) (2020-09-30) ### Bug Fixes * potential NRE with weaver errors ([9e0c18c](9e0c18c)) ### Features * You can use synclists directly ([#366](#366)) ([ca18d11](ca18d11)) ### BREAKING CHANGES * SyncList and other syncobjects no longer have override methods to serialize and deserialize data
|
🎉 This PR is included in version 46.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you had to write a class that extended synclist to make the weaver happy.
Now the weaver does not need to generate code for synclists anymore,
so you can use synclists as <insert your deity> intended.
before
after
BREAKING CHANGE: SyncList and other syncobjects no longer have override methods to serialize and deserialize data