Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display user-friendly log with an unexpected messages. #417

Merged
merged 7 commits into from
Oct 20, 2020
Merged

feat: display user-friendly log with an unexpected messages. #417

merged 7 commits into from
Oct 20, 2020

Conversation

paulpach
Copy link
Contributor

@paulpach paulpach commented Oct 20, 2020 •
edited

display user-friendly log with an unexpected messages.

Before:

Unknown message ID 1234 connection(...). May be due to no existing RegisterHandler for this message.

After:

"Unexpected message Mirror.SceneMessage received in connection(...). Did you register a handler for it?"

@paulpach paulpach marked this pull request as ready for review October 20, 2020 17:31
@paulpach paulpach changed the title feat: Figure out message name when we receive unknown message feat: display user-friendly log with an unexpected messages. Oct 20, 2020
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

97.8% 97.8% Coverage
0.0% 0.0% Duplication

@paulpach paulpach merged commit 7b78c29 into master Oct 20, 2020
@paulpach paulpach deleted the unknownid branch October 20, 2020 18:52
github-actions bot pushed a commit that referenced this pull request Oct 20, 2020
@semantic-release-bot
chore(release): 50.2.0 [skip ci]
ccf42d7 
# [50.2.0](v50.1.5...v50.2.0) (2020-10-20)

### Bug Fixes

* method access exception sending rpcs ([531e908](531e908))

### Features

* display user-friendly log with an unexpected messages. ([#417](#417)) ([7b78c29](7b78c29))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 50.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lymdun Lymdun Lymdun approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulpach @Lymdun